Add tests for the app exit confirmation behavior #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nt4f04uNd
force-pushed
the
1.0.8
branch
3 times, most recently
from
b91a21f
to
ca3eadc
Compare
nt4f04uNd
reviewed
May 11, 2022
nt4f04uNd
reviewed
May 11, 2022
Abestanis
force-pushed
the
test/appExitConfirmation
branch
2 times, most recently
from
368b798
to
1670f19
Compare
nt4f04uNd
reviewed
May 12, 2022
nt4f04uNd
reviewed
May 12, 2022
Abestanis
force-pushed
the
test/appExitConfirmation
branch
from
cf33494
to
3a1ff23
Compare
|
This is much better now, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds test for the app exit confirmation behavior and the setting introduced in dart-lang/test#2343. Tests for the new settings screen are not included.
I'm not super familiar with Flutter testing, if you have an ideas on how to improve these, I would be happy to hear them.
I'm also not supper happy about hard-coding the flutter toast package method channel name and the method names, but I don't see any other way.
I also manually tested that switching from
DateTimeto the to theclockpackage doesn't change how the back button confirm timeout works.