Skip to content

Commit

Permalink
chore: bumped version to 0.9.1
Browse files Browse the repository at this point in the history
  • Loading branch information
@ntamas
ntamas committed Dec 1, 2021
1 parent 6157c71 commit c8c2a3b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ list(APPEND CMAKE_MODULE_PATH ${CMAKE_CURRENT_LIST_DIR}/etc/cmake)

project(
plfit
VERSION 0.9.0
VERSION 0.9.1
DESCRIPTION "Library to fitt power-law distributions to empirical data"
HOMEPAGE_URL "https://github.com/ntamas/plfit"
LANGUAGES C
Expand Down

7 comments on commit c8c2a3b

@jgmbenoit
Copy link
Contributor

@jgmbenoit jgmbenoit commented on c8c2a3b Dec 11, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a Debian Sid amd64 environment, test_xmin_too_low now emits some disturbing messages towards stderr but it exits successfully: is it expected ?
The messages are:
Testing smallest x less than 1 but there are enough distinct values in the remainder after skipping them...
Testing smallest x less than 1 and there are not enough distinct values in the remainder after skipping them (1)...
Testing smallest x less than 1 and there are not enough distinct values in the remainder after skipping them (2)...

@ntamas
Copy link
Owner Author

@ntamas ntamas commented on c8c2a3b Dec 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's fine, the RUN_TEST_CASE() macro prints a title for the test case being executed. You can ignore it.

@jgmbenoit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your reply. I manage this by sending the label message to stdin instead to stderr so that tests do not trigger a failure because of an non-empty stderr log file.

@jgmbenoit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I suggest to install the headers in a plfit folder as igraph installs its headers in igraph folder ?
This may simplify the integration of codes to build igraph against an external plfit library.

@ntamas
Copy link
Owner Author

@ntamas ntamas commented on c8c2a3b Dec 19, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6cfe999 now redirects 'normal' (i.e. expected) test case output to stdout.
d41ffd7 installs headers in ${includedir}/plfit.

I also bumped the version number to 1.0.0 as I think it's time to commit myself to a stable API/API :) (Not committed yet).

Before I make 1.0.0 official: would you like me to bump the SOVERSION to 1 or is it easier for you to keep it at 0 for the time being?

@jgmbenoit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to give a try to a version 0.9.2 version. Concerning the ABI/API, bumping to SOVERSION 1 will not complicate my task.

@ntamas
Copy link
Owner Author

@ntamas ntamas commented on c8c2a3b Dec 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.9.2 is now tagged. SOVERSION is still at zero; I'll bump it to 1 when the version number is bumped to 1.0.0.

Please sign in to comment.