Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some roadmapping #10

Merged
merged 3 commits into from
Dec 22, 2023
Merged

Some roadmapping #10

merged 3 commits into from
Dec 22, 2023

Conversation

rgbkrk
Copy link
Member

@rgbkrk rgbkrk commented Dec 21, 2023

Taking pieces from #6 and #7 to make an initial ROADMAP and messaging outline.

@kafonek
Copy link
Contributor

kafonek commented Dec 22, 2023

Looks good to me @rgbkrk. Two places that I think need a touch more detail, although it may only come after we start iterating on code:

  • From backend perspective, there should be one central Tauri process -> many Sidecars (which means in-memory Notebook and ZMQ connection management), just like one Jupyter server -> Kernels (only managing ZMQ connections) right? Are you constraining the phase 1 work to the Tauri app spawning Jupyter Kernels (ipykernel, deno, etc) as subprocesses?
  • I'm writing kernel-sidecar to run in a tokio runtime, is that compatible with how you're rolling out the initial Tauri app?

@rgbkrk
Copy link
Member Author

rgbkrk commented Dec 22, 2023

I'm writing kernel-sidecar to run in a tokio runtime, is that compatible with how you're rolling out the initial Tauri app?

tokio all the way -- happy to stay in that ecosystem alongside deno

From backend perspective, there should be one central Tauri process -> many Sidecars (which means in-memory Notebook and ZMQ connection management), just like one Jupyter server -> Kernels (only managing ZMQ connections) right? Are you constraining the phase 1 work to the Tauri app spawning Jupyter Kernels (ipykernel, deno, etc) as subprocesses?

Ok great, useful for me to know about. I just assumed based on https://github.com/kafonek/kernel-sidecar-rs/blob/main/src/main.rs that kernel sidecar was launching the subprocess. I can update the doc & diagram.

@rgbkrk rgbkrk merged commit 93f768b into main Dec 22, 2023
@rgbkrk rgbkrk deleted the some-roadmapping branch December 22, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants