Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added postBuild to fix pip install issues with pip 19 #349

Merged
merged 1 commit into from
Apr 27, 2019

Conversation

MSeal
Copy link
Member

@MSeal MSeal commented Apr 27, 2019

Fixes #348

Tested against my branch at https://hub.mybinder.org/user/mseal-papermill-4d7pfjpg/notebooks/binder/cli-simple/cli_example.ipynb

See pypa/pip#6433 for why this caused us problem with pip 19 upgrade.

@mpacer
Copy link
Member

mpacer commented Apr 27, 2019

Lgtm

@mpacer mpacer merged commit 7423a30 into nteract:master Apr 27, 2019
@betatim
Copy link
Member

betatim commented Apr 28, 2019

n.b. the link to share is https://mybinder.org/v2/gh/MSeal/papermill/binderFix the other one takes you to your personal ephemeral session. (Ideas on how to fix this UX annoyance welcome, it is tricky :-/)

@MSeal MSeal deleted the binderFix branch August 18, 2020 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mybinder.org build broken because of setup.py and pyproject.toml presence
3 participants