Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent error override, fix traceback type #788

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

mbektas
Copy link
Contributor

@mbektas mbektas commented Apr 2, 2024

this is in addition to #786

  • fixing overriding regular error type detection.
  • making traceback an empty list instead of empty string

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Merging #788 (1691811) into main (cb2eb37) will decrease coverage by 0.26%.
Report is 6 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #788      +/-   ##
==========================================
- Coverage   91.54%   91.29%   -0.26%     
==========================================
  Files          17       17              
  Lines        1621     1631      +10     
==========================================
+ Hits         1484     1489       +5     
- Misses        137      142       +5     

@MSeal MSeal merged commit 51a7c29 into nteract:main Apr 2, 2024
12 of 13 checks passed
@MSeal
Copy link
Member

MSeal commented Apr 2, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants