Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Modernize setuptools packaging with pyproject.toml #158

Merged
merged 17 commits into from
Aug 25, 2024

Conversation

rohitsanj
Copy link
Member

@rohitsanj rohitsanj commented Aug 3, 2024

Summary of changes

  • Deprecate and remove setup.py in favor of more modern pyproject.toml -- we continue to use setuptools for packaging.
  • Minor doc updates
  • Replace flake8 and black with ruff
  • Formatted all source files with tox -e format (Enforce single-quoted strings)
  • Remove support for end-of-life Python versions 3.6 and 3.7
  • Update copyright year to 2024

References:

@rohitsanj rohitsanj changed the title Modernize setuptools packaging and automate releases Modernize setuptools packaging Aug 3, 2024
@rohitsanj rohitsanj changed the title Modernize setuptools packaging chore: Modernize setuptools packaging Aug 3, 2024
@rohitsanj rohitsanj changed the title chore: Modernize setuptools packaging chore: Modernize setuptools packaging with pyproject.toml Aug 3, 2024
@rohitsanj rohitsanj marked this pull request as ready for review August 3, 2024 17:17
@rohitsanj rohitsanj requested a review from MSeal August 3, 2024 17:17
@rohitsanj
Copy link
Member Author

Ignore the "1 failed deployment" -- I was testing the actions workflow for deploying to testpypi.

Copy link
Member

@MSeal MSeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor note, our contributing instructions talk about using -e in install but that won't work without a setup.cfg I believe. Otherwise everything worked as expected that I tested out locally.

@rohitsanj
Copy link
Member Author

Thanks for the review.

FWIW, I was able to run pip install -e '.[dev]' without any issues.

@rohitsanj rohitsanj merged commit 9d48dbb into nteract:main Aug 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants