Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor control messages #170

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Refactor control messages #170

merged 2 commits into from
Apr 15, 2024

Conversation

fafhrd91
Copy link
Member

No description provided.

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 41.05960% with 178 lines in your changes are missing coverage. Please review.

Project coverage is 70.64%. Comparing base (5912642) to head (0a37d72).

Files Patch % Lines
src/v3/control.rs 46.66% 24 Missing ⚠️
src/v5/control.rs 51.06% 23 Missing ⚠️
src/v5/client/control.rs 25.00% 21 Missing ⚠️
src/v5/client/dispatcher.rs 30.76% 18 Missing ⚠️
src/v3/client/dispatcher.rs 26.08% 17 Missing ⚠️
src/v3/dispatcher.rs 51.42% 17 Missing ⚠️
src/v5/dispatcher.rs 48.48% 17 Missing ⚠️
src/v3/client/control.rs 23.80% 16 Missing ⚠️
src/v5/mod.rs 0.00% 10 Missing ⚠️
src/v3/client/connection.rs 16.66% 5 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
+ Coverage   66.58%   70.64%   +4.06%     
==========================================
  Files          53       52       -1     
  Lines        9246     8677     -569     
==========================================
- Hits         6156     6130      -26     
+ Misses       3090     2547     -543     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fafhrd91 fafhrd91 force-pushed the control-message branch 2 times, most recently from 5c7e3e2 to cc69135 Compare April 15, 2024 16:26
@fafhrd91 fafhrd91 merged commit 184fc53 into master Apr 15, 2024
18 of 21 checks passed
@fafhrd91 fafhrd91 deleted the control-message branch April 15, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant