Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

feat: Update JSDocs. #6

Merged
merged 8 commits into from
Oct 29, 2021
Merged

feat: Update JSDocs. #6

merged 8 commits into from
Oct 29, 2021

Conversation

WiseDevHelper
Copy link
Collaborator

Resolves #5.

@WiseDevHelper WiseDevHelper self-assigned this Oct 28, 2021
@WiseDevHelper WiseDevHelper marked this pull request as ready for review October 28, 2021 16:52
NTMNathan
NTMNathan reviewed Oct 28, 2021
View reviewed changes
src/lib/custom.js Outdated Show resolved Hide resolved
NTMNathan
NTMNathan reviewed Oct 28, 2021
View reviewed changes
src/lib/custom.js Outdated Show resolved Hide resolved
NTMNathan
NTMNathan reviewed Oct 28, 2021
View reviewed changes
src/lib/generators.js Outdated Show resolved Hide resolved
NTMNathan
NTMNathan suggested changes Oct 28, 2021
View reviewed changes
Copy link
Member

@NTMNathan NTMNathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, as long it's able to address the problems below. It should be good.

Also don't forget the do the typings. I cannot find any changes for it.

NTMNathan
NTMNathan reviewed Oct 29, 2021
View reviewed changes
typings/lib/custom.d.ts Outdated Show resolved Hide resolved
NTMNathan
NTMNathan reviewed Oct 29, 2021
View reviewed changes
typings/lib/custom.d.ts Outdated Show resolved Hide resolved
NTMNathan
NTMNathan suggested changes Oct 29, 2021
View reviewed changes
Copy link
Member

@NTMNathan NTMNathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome what you've done!

Just those changes, and we're good to go...

NTMNathan
NTMNathan approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@NTMNathan NTMNathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect.

@NTMNathan NTMNathan merged commit 3db7e01 into ntm-development:main Oct 29, 2021
@WiseDevHelper WiseDevHelper deleted the feat/jsdocs branch October 29, 2021 12:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NTMNathan NTMNathan NTMNathan approved these changes

Assignees

@WiseDevHelper WiseDevHelper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NEEDED] Improve JSDoc documentation
2 participants
@WiseDevHelper @NTMNathan