Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tile API Update #123

Merged
merged 69 commits into from
Feb 3, 2023
Merged

Tile API Update #123

merged 69 commits into from
Feb 3, 2023

Conversation

ntno
Copy link
Owner

@ntno ntno commented Feb 1, 2023

CSS Refactor

  • moved tile grid specific CSS to separate file
  • center image within tile

Tile Grid API Update

Tile API

removed image width/height attributes

  • img_width removed; use tile_css instead
  • img_height removed; use tile_css instead

replaced title attributes with new tooltip attribute

  • img_title -> tooltip
  • link_title -> tooltip

simplify alternate text specification, use alt_text to describe image or link

  • img_alt -> alt_text
  • link_text -> alt_text

Documentation Updates

  • added alt text guidance
  • added links to additional resources on writing alt text
  • note that alt text should be a link description for a linked image tile (see discussion in review accessibility of linked image tile #107)
  • updated tile examples

Test Updates

  • unit tests updated

Checklist

  • I have added documentation for new/changed functionality in this PR or in mkdocs-terminal/documentation
  • All active GitHub checks for tests, formatting, and security are passing

ntno added 30 commits February 1, 2023 15:24
* initial

* image only example should provide image description

* text should specify where the link goes for linked images

* updated link examples

* add image alt text

* remove unecessary link

* remove link

* remove links in inline example

* link figcaption

* move tooltip to link in the figcaption

* fix find/replace error

* title->tooltip

* text -> alt_text
@ntno ntno merged commit 1828036 into main Feb 3, 2023
@ntno ntno deleted the tile-api-update branch February 3, 2023 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant