Skip to content

side navigation hide improvement #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Apr 15, 2023
Merged

side navigation hide improvement #130

merged 17 commits into from
Apr 15, 2023

Conversation

ntno
Copy link
Owner

@ntno ntno commented Apr 15, 2023 •
edited
Loading

improve side navigation hiding

use one column grid layout when navigation.side.hide is enabled. this places the main page content directly underneath the site title instead of leaving a blank column where the side navigation panel is usually displayed.

before

hiding-on-4 3

after

hiding-on-with-proposed-4 4-change

References

resolves #129

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in mkdocs-terminal/documentation
  • All active GitHub checks for tests, formatting, and security are passing

@ntno ntno mentioned this pull request Apr 15, 2023
Closed
@ntno ntno merged commit 7d88d64 into main Apr 15, 2023
@ntno ntno deleted the side-nav-hide-improvement branch April 15, 2023 19:03
@ntno ntno added the enhancement New feature or request label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

navigation.side.hide feature leaves an empty space on the side
1 participant
@ntno