Datepicker legacy vue3 support (#112) #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds test cases:
1. Tests if `DatepickerTableRow` calls `focus` on the corresponding
date cell when `day` is updated
2. Tests if `DatepickerMont` calls `focus` on the corresponding date
cell when `focusedMonth` is updated
These tests are intended to make sure `Datepicker` works both with Vue
before 3.2.25, and Vue 3.2.25 or later.
- Fixes the following bugs:
- `DatepickerTableRow` did not call `focus` on the corresponding
date cell when `day` is updated
- `DatepickerMonth` did not call `focus` on the corresponding month
cell when `focusedMonth` is updated
The bugs were caused due to the change in Vue's behavior from v3.2.24
to v3.2.25; `ref`s in v-for are stored as a single object in v3.2.24
or earlier, but in an array in v3.2.25 or later.
The fixed code works both with Vue v3.2.24 or earlier, and v3.2.25 or
later.
wesdevpro
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed Changes
DatepickerTableRowandDatepickerMonthso that they work both with Vue v3.2.24 or earlier, and Vue v3.2.25 or laterrefcombined withv-foris stored as a single object in$refson Vue v3.2.24 or earlier, but stored in an array on Vue v3.2.25 or later