Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to Bulma v1.0 #295

Merged
merged 8 commits into from
Jan 22, 2025
Merged

Conversation

gmercey
Copy link

@gmercey gmercey commented Nov 4, 2024

Migrating component and documentation to Bulma V1.0
https://bulma.io/documentation/start/migrating-to-v1/

@wesdevpro wesdevpro assigned wesdevpro and gmercey and unassigned wesdevpro Nov 4, 2024
@wesdevpro wesdevpro added the enhancement New feature or request label Nov 4, 2024

Verified

This commit was signed with the committer’s verified signature.
suemto suem
@dword-design
Copy link

This looks very promising already 😊.

@Tharabas
Copy link

Is there any plan to progress here?

@wesdevpro
Copy link

wesdevpro commented Jan 16, 2025

Is there any plan to progress here?

Yes! There are plans to officially migrate from Bulma v0.9.x to Bulma v1. For the moment @kikuomax and I are working on completing the TS migration which will be published in v0.2.0 buefy-next (See #151). There are also some bugs that will need fixing from versions 0.2.x to 0.3.x (Bulma v1 support)

Thanks @gmercey for taking the migration on early! It looks very promising

@gmercey
Copy link
Author

gmercey commented Jan 16, 2025

Is there any plan to progress here?

I just updated the PR to resolve conflicts. Overall everything looks good on my end, I have my work running on production for a little while now.

@wesdevpro
Copy link

Is there any plan to progress here?

I just updated the PR to resolve conflicts. Overall everything looks good on my end, I have my work running on production for a little while now.

Sweet! Have you run into any issues?

@kikuomax
Copy link
Collaborator

@gmercey I will look into your PR after releasing v0.2.0 which will mostly consist of the TypeScript migration.

@gmercey
Copy link
Author

gmercey commented Jan 17, 2025

Is there any plan to progress here?

I just updated the PR to resolve conflicts. Overall everything looks good on my end, I have my work running on production for a little while now.

Sweet! Have you run into any issues?

There are a few button states (e.g: primary outlined loading) that need some teaks but overall the CSS works great. I also keep my branch in sync with the dev branch, and so far, I didn't encounter any issues.

@wesdevpro wesdevpro changed the base branch from dev to migrate-to-bulma-v1 January 22, 2025 14:35
@wesdevpro wesdevpro merged commit 2b734b0 into ntohq:migrate-to-bulma-v1 Jan 22, 2025
0 of 18 checks passed
@wesdevpro wesdevpro added this to the v0.3.0 milestone Mar 6, 2025
kikuomax pushed a commit that referenced this pull request Mar 7, 2025
Rebasing notes:
- Hoists `bulma` to the workspace root.
- Adds `--load-path=../../node_modules` to the `sass` command in the
  `build:scss` command, because `bulma` is likely installed in the
  workspace root.
- (docs) Removes `bulma-css-vars` from `docs`'s dependencies, because it
  requires Bulma v0.9. So the extension page of `bulma-css-vars` no
  longer works.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants