TypeScript Rollout Tier 9 - Clockpicker #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrites the clockpicker components in the `src/components/clockpicker` folder in TypeScript. In `ClockpickerFace.vue`: - Introduces a new interface `FaceNumber` which represents the item type of the `faceNumbers` prop Common changes: - Registers other Buefy components with "direct" names instead of the `name` fields so that they are type-checked
Rewrites the specs for the clockpicker components in the `src/components/clockpicker` in TypeScript. All the changes are straightforward. Here are common changes: - Imports the spec building blocks from the `vitest` package - Replaces `jest` with `vi` In the `__snapshots__` subfolder, replaces the spec snapshots produced by Jest with those by Vitest: - `Clockpicker.spec.(js → ts).snap` - `ClockpickerFace.spec.(js → ts).snap`
`rollup.config.mjs` removes "clockpicker" from `JS_COMPONENTS`.
Rewrites the documentation for the clockpicker components in the `src/pages/components/clockpicker` in TypeScript. All the changes are straightforward. Here is a TypeScript migration tip: - Explicitly import and register components so that they are type checked. No type-checking is performed for globally registered components.
wesdevpro
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues:
Proposed Changes
clockpickerpackages/buefy-next/rollup.config.mjswill likely cause a conflict after merging the other PRs in this tier.