Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript Rollout Tier 17 - docs router #408

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

kikuomax
Copy link
Collaborator

@kikuomax kikuomax commented Jan 17, 2025

Related issues:

Proposed Changes

  • Migration of packages/docs/src/router

Rewrites the router defined in the `src/router` folder in TypeScript.

In `index.(js → ts)`:
- Augments the `RouteMeta` interface provided by `vue-router` with the
  `Route` interface defined in `src/data/routes.ts` so that the
  application can access the current `Route` information through the Vue
  router's meta data without any type error.

Common benign changes:
- Removes unused method parameters
@kikuomax kikuomax requested a review from wesdevpro January 17, 2025 14:11
Copy link

@wesdevpro wesdevpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🏎️💨

@kikuomax kikuomax merged commit fb9c6ad into ntohq:dev Jan 17, 2025
18 checks passed
@kikuomax kikuomax deleted the ts-rollout-tier-17-docs-router branch January 17, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript Rollout Tier 17 - docs
2 participants