Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle MIT License in NPM Package #412

Merged
merged 1 commit into from
Jan 18, 2025
Merged

Bundle MIT License in NPM Package #412

merged 1 commit into from
Jan 18, 2025

Conversation

wesdevpro
Copy link

@wesdevpro wesdevpro commented Jan 17, 2025 •
edited
Loading

Fixes #276

Proposed Changes

  • Copy the Buefy MIT license to the root of the buefy-next package workspace.

How to test?

  1. Checkout the BundleLicense branch.
  2. cd to the buefy-next workspace.
  3. Run npm i
  4. Run npm pack
  5. Make a temp directory (mkdir tmp)
  6. Move the newly generate tgz file to the tmp directory.
  7. Extract its contents into the tmp folder using tar.
  8. open the newly created packages folder.
  9. You should see LICENSE.md with in that bundled package.

Testing Evidence

image

@wesdevpro wesdevpro requested review from kikuomax, wesbyte29 and a team January 17, 2025 22:13
@wesdevpro wesdevpro self-assigned this Jan 17, 2025
@wesdevpro wesdevpro requested review from dword-design and removed request for a team January 17, 2025 22:13
kikuomax
kikuomax approved these changes Jan 18, 2025
View reviewed changes
Copy link
Collaborator

@kikuomax kikuomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wesdevpro wesdevpro merged commit 3f4749f into dev Jan 18, 2025
18 checks passed
@wesdevpro wesdevpro deleted the BundleLicense branch January 18, 2025 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kikuomax kikuomax kikuomax approved these changes

@wesbyte29 wesbyte29 Awaiting requested review from wesbyte29

@dword-design dword-design Awaiting requested review from dword-design dword-design was automatically assigned from ntohq/buefy-vue3-development-team

Assignees

@wesdevpro wesdevpro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

License file missing in NPM package
2 participants
@wesdevpro @kikuomax