Port spec for Numberinput #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reimplements the test case "increments/decrements on long pressing
exponentially" due to its flaky results. It used to use the real timer
to simulate a long press, however, this depended on the machine
running the test. It now uses Jest's fake timer to make the test case
deterministic. There were subtle details I had to take into account to
confidently wrote a test:
- Jest's fake `setTimeout` truncates a given `delay` to an extact ms
when it schedules a callback.
- `jest.advanceTimersByTime` also truncates a given `msToRun` but
accumulates the remainders. It advances an extra millisecond when
the accumulated remainders becomes large enough.
- I decided to floor the input for `jest.advanceTimersByTime` to
prevent the accumulated remainder from triggering an extra
callback. This may look counter-intuitive if you look into the
source code of `Numberinput`, because it does not floor the delay
before passing it to `setTimeout`. Although, according to the
above Jest's behavior, I am confident with my decision.
- Updates the unit tests (spec) of `Numberinput` so that they can work
with `@vue/test-utils` V2:
- Supplies a fake component that mocks `checkHtml5Validity` as a
stub of `b-input` in the test group "Rendered (shallow)", because
the entire tests aborted due to missing `checkHtml5Validity`.
In `@vue/test-utils` V1, `shallowMount` catches an error thrown
from mounted component, warns it, and continues, but in V2, it
bubbles the error and ends up with a crash.
- Corrects the v-model property: `value` → `modelValue`.
- Replaces `wrapper.contains` with a combination of `find` and
`exists` because `wrapper.contains` no longer exists in
`@vue/test-utils` V2.
- Awaits `wrapper.setProps` to make sure the subsequent tests verify
the updated state.
- Replaces direct data modification with `wrapper.setData` and
awaits it to make sure the subsequent tests verify the updated
state.
- Replaces `wrapper.name()` with `wrapper.vm.$options.name` because
`wrapper.name` no longer exists in `@vue/test-utils` V2.
- Replaces the test on `wrapper.isVueInstance()` with presence of
`wrapper.vm` because `wrapper.isVueInstance` no longer exists in
`@vue/test-utils` V2.
issue ntohq#1
wesdevpro
approved these changes
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the series of PRs to port unit tests.
The following command should pass:
You will see the following warning while running the tests, but it is fine because it happens only in the test environment:
Related to:
Proposed Changes