Port spec for Collapse #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updates the unit tests (spec) of `Collapse` so that they can work with
`@vue/test-utils` V2 and breaking changes:
- Replaces mock functions to test emitted events with tests on
`wrapper.emitted`.
- Corrects the v-model bindings:
- property: `open` → `modelValue`
- event: `update:open` → `update:modelValue`
- Awaits `wrapper.setProps` to make sure the subsequent tests verify
the updated state.
- Waits after "click" events.
- Replaces `wrapper.name()` with `wrapper.vm.$options.name` because
`wrapper.name` no longer exists in `@vue/test-utils` V2.
- Replaces the test on `wrapper.isVueInstance()` with presence of
`wrapper.vm` because `wrapper.isVueInstance` no longer exists in
`@vue/test-utils` V2.
- Removes the test case "should have scoped trigger slot" because
`scopedSlots` is integrated into `slots` on `@vue/test-utils` V2.
- Replaces `propsData` option for `shallowMount` with `props`
because `propsData` might be deprecated in the future.
- Refreshes the snapshot. I found "aria-expanded" attribute has
disappeared from the updated snapshot, though, I believe the
updated snapshot is legitimate.
issue ntohq#1
wesdevpro
approved these changes
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the series of PRs to port unit tests.
The following command should pass:
You will see the following warning while running the tests. This is due to the issue #26 but should not matter to the test results:
Related to:
Proposed Changes