Port spec for Navbar #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updates the unit tests (spec) of `Navbar` so that they can work with
`@vue/test-utils` V2 and breaking changes:
- Corrects v-model bindings:
- property: `active` → `modelValue`
- event: `update:active` → `update:modelValue`
- Replaces `wrapper.contains` with a combination of `find` and
`exists` because `wrapper.contains` no longer exists in
`@vue/test-utils` V2.
- Awaits `wrapper.setProps` and `wrapper.trigger` to make sure the
subsequent tests verify the updated state.
- Replaces the test on `wrapper.isVueInstance()` with presence of
`wrapper.vm` because `wrapper.isVueInstance` no longer exists in
`@vue/test-utils` V2.
- Replaces `propsData` for `mount` with `props` because `propsData`
might be deprecated in the future.
- Refreshes the snapshot. I did not find any problems in the updated
snapshot. However, the snpshot won't match until we fix the issue
ntohq#29.
- The tests won't pass until we fix the issue ntohq#28.
issue ntohq#1
- Updates the unit tests (spec) of `NavbarBurger` so that they can work
with `@vue/test-utils` V2:
- Specifies the element tag to the selector given to `wrapper.find`
instead of testing the tag with `is`. Because `is` no longer
exists in `@vue/test-utils` V2.
- Awaits `wrapper.setProps` to make sure the subsequent assertions
verify the updated state.
- Replaces the test on `wrapper.isVueInstance()` with presence of
`wrapper.vm` because `wrapper.isVueInstance` no longer exists in
`@vue/test-utils` V2.
- Refreshes the snapshot. I did not find any problems in the updated
snapshot. However, the snapshot won't match until we fix the issue
ntohq#29.
issue ntohq#1
- Updates the unit tests (spec) of `NavbarItem` so that they can work
with `@vue/test-utils` V2 and Vue 3:
- Replaces `listeners` option for `shallowMount` with `on{event}`
props, because `listeners` no longer works on `@vue/test-utils` V2
but `on{event}` prop does the equivalent job on Vue 3 instead.
- Mounts `stubBNavBar` and inserts `BNavbarItem` into its default
slot instead of specifying `stubBNavBar` as `parentComponents`,
because `parentComponents` no longer works on `@vue/test-utils`
V2.
- Replaces `wrapper.contains` with a combination of `find` and
`exists` because `wrapper.contains` no longer exists in
`@vue/test-utils` V2.
- A test on a tag name is merged with a selector given to `find`.
- Awaits `wrapper.setProps` to make sure the subsequent assertions
verify the updated state.
- Replaces `wrapper.name()` with `wrapper.vm.$options.name` because
`wrapper.name` no longer exists in `@vue/test-utils` V2.
- Replaces the test on `wrapper.isVueInstance()` with presence of
`wrapper.vm` because `wrapper.isVueInstance` no longer exists in
`@vue/test-utils` V2.
- Fixes the event type for "click": `KeyboardEvent` → `MouseEvent`.
- Replaces `sinon.stub` with `jest.fn`. No longer imports `sinon`.
issue ntohq#1
- Updates the unit tests (spec) of `NavbarDropdown` so that they can
work with `@vue/test-utils` V2:
- Awaits `wrapper.setProps` to make sure the subsequent assertions
verify the updated state.
- Replaces `wrapper.name()` with `wrapper.vm.$options.name` because
`wrapper.name` no longer exists in `@vue/test-utils` V2.
- Replaces the test on `wrapper.isVueInstance()` with presence of
`wrapper.vm` because `wrapper.isVueInstance` no loger exists in
`@vue/test-utils` V2.
- Refreshes the snapshot. I found the updated snapshot had two
`div` elements with `navbar-dropdown` class, but this is fine
because they were introduced after the old snapshot was recorded.
issue ntohq#1
wesdevpro
approved these changes
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the series of PRs to port unit tests.
The following command should pass:
Related to:
Proposed Changes