Line: fix heap-buffer-overflow error (#2015)

ntop · Jun 21, 2023 · 46aab35 · 46aab35
1 parent 3608ab0
commit 46aab35
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/lib/protocols/line.c b/src/lib/protocols/line.c
@@ -63,7 +63,7 @@ static void ndpi_search_line(struct ndpi_detection_module_struct *ndpi_struct,
     if ((packet->payload_packet_len == 46 && ntohl(get_u_int32_t(packet->payload, 0)) == 0xb6130006) ||
 	(packet->payload_packet_len == 8 && ntohl(get_u_int32_t(packet->payload, 0)) == 0xb6070004) ||
 	(packet->payload_packet_len == 16 && ntohl(get_u_int32_t(packet->payload, 0)) == 0xb609000c) ||
-	(ndpi_struct->packet.payload[0] == 0xD0 &&
+	(packet->payload_packet_len >= 2 /* TODO */ && ndpi_struct->packet.payload[0] == 0xD0 &&
 	 (ndpi_struct->packet.payload[1] == 0xB3 || ndpi_struct->packet.payload[1] == 0xB4
 	  || ndpi_struct->packet.payload[1] == 0xDA || ndpi_struct->packet.payload[1] == 0xDB))) {
       ndpi_int_line_add_connection(ndpi_struct, flow);