Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed LGTM ql query for packet payload integer arithmetic. #1570

Merged
merged 1 commit into from
May 31, 2022

Conversation

utoni
Copy link
Collaborator

@utoni utoni commented May 31, 2022

  • Detection is unreliable and results in too much false-positives (and false-negatives!)

Signed-off-by: lns matzeton@googlemail.com

 * Detection is unreliable and results in too much false-positives (and false-negatives!)

Signed-off-by: lns <matzeton@googlemail.com>
@utoni utoni force-pushed the remove/lgtm-network-arithm branch from b6c440c to 906fb91 Compare May 31, 2022 13:30
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@IvanNardi
Copy link
Collaborator

I couldn't agree more.
I'll happily merge this PR

@IvanNardi IvanNardi merged commit 00c62a7 into ntop:dev May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants