Realtime output detected protocol #2059
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utoni
reviewed
Jul 27, 2023
| firsttime = flow->first_seen_ms / TICK_RESOLUTION; | ||
| localtime_r(&firsttime, &tm); | ||
|
|
||
| strftime(stime, sizeof(stime), "%T", &tm ); |
There was a problem hiding this comment.
Please replace the time format %T with %H:%M:%S.
There was a problem hiding this comment.
Thank you for your advice. I will fix it.
utoni
reviewed
Jul 27, 2023
Co-authored-by: Toni <matzeton@googlemail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
IvanNardi
requested changes
Jul 28, 2023
IvanNardi
reviewed
Jul 28, 2023
| /** | ||
| * @brief From IPPROTO to string NAME | ||
| */ | ||
| static char* ipProto2Name(u_int16_t proto_id) { |
There was a problem hiding this comment.
Could you use ndpi_get_ip_proto_name instead?
IvanNardi
reviewed
Jul 28, 2023
| return(proto); | ||
| } | ||
|
|
||
| static int specific_protos[12] = { |
There was a problem hiding this comment.
Could you move this array into is_specific_protocol(), please?
|
@Anton-89, any updates on this PR? |
|
Replaced by #2197. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.