Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: update to latest macOS runners #2293

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

IvanNardi
Copy link
Collaborator

@IvanNardi IvanNardi commented Jan 30, 2024

Add a simple job with macos-14 on M1.
https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/)
There are some issues with external dependencies (they are installed but
autoconf script doens;t find them) so keep it simple.

On macos-13 it seems that:

  • there is no realpath program (even if coreutils has been
    installed...)
  • most of the filesystem is read only (we can't write on /usr/lib).

So I change

make install DESTDIR=$(realpath _install)
ls -alhHR _install

to

DESTDIR=/tmp/ndpi make install
ls -alhHR /tmp/ndpi

for all the jobs

Fix a warning on GitHub logs:

Node.js 16 actions are deprecated. Please update the following actions
to use Node.js 20: actions/checkout@v3. For more information see:
https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

@IvanNardi IvanNardi force-pushed the mac-runners branch 18 times, most recently from 9bc822f to 732fb27 Compare January 31, 2024 12:30
@IvanNardi IvanNardi changed the title GitHub Actions: update to latest macOS runners (with M1) GitHub Actions: update to latest macOS runners Jan 31, 2024
@IvanNardi IvanNardi requested a review from utoni January 31, 2024 12:49
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
@IvanNardi IvanNardi force-pushed the mac-runners branch 3 times, most recently from 4809c4f to 152b990 Compare January 31, 2024 16:13
Add a simple job with macos-14 on M1.
https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/)
There are some issues with external dependencies (they are installed but
autoconf script doens;t find them) so keep it simple.

On macos-13 it seems that:
* there is no `realpath` program (even if coreutils has been
installed...)
* most of the filesystem is read only (we can't write on /usr/lib).
So I change
```
make install DESTDIR=$(realpath _install)
ls -alhHR _install
```
to
```
DESTDIR=/tmp/ndpi make install
ls -alhHR /tmp/ndpi
```
for all the jobs

Fix a warning on GitHub logs:
```
Node.js 16 actions are deprecated. Please update the following actions
to use Node.js 20: actions/checkout@v3. For more information see:
https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
```
Copy link

sonarcloud bot commented Jan 31, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@IvanNardi IvanNardi merged commit 8fbef7f into ntop:dev Feb 1, 2024
32 checks passed
@IvanNardi IvanNardi deleted the mac-runners branch February 1, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants