-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Used to identify the Automatic Tank Gauge protocol #2527
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes:
- add
<ClCompile Include="..\src\lib\protocols\atg.c" />
towindows/nDPI.vcxproj
(like you did in previous PR) - update results files:
NDPI_FORCE_UPDATING_UTESTS_RESULTS=1 ./tests/do.sh
and "git add" all changed and new files
LGTM. @utoni, @koltiradw, @0xA50C1A1 any comment? |
@wssxsxxsx, could you sign the CLA, please? |
@IvanNardi Is it to send the CLA by email? I have already sent it. |
No you don't, but I don't find your GitHub name (wssxsxxsx) in the list of the people who signed it. Could you double check, please? |
@IvanNardi Is it sent here-> legal@ntop.org |
I think it would be good to add some additional checks, in case this protocol can use a port different from 10001. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed some cosmetithic changes.
I think this PR is fine; we can always improve the detection later, if needed
Thanks @wssxsxxsx for your work and your perseverance! |
Please sign (check) the below before submitting the Pull Request:
Link to the related issue:
Describe changes: