-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow MVNA api spec changes #80
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysssasaki
reviewed
May 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🦈
t-wata
approved these changes
May 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🦈
ysssasaki
approved these changes
May 18, 2021
sugimo-s
added a commit
that referenced
this pull request
Feb 18, 2022
* Add MVNA Resource. (#74) * Support additional mvna parameter (#76) * Support List Query Parameters. * Support changes query parameter. * Support X-MVNA-Request-Id Header Parameter. * Add `ignore_missing` argument to delete_load_balancer function. * Refactoring the code. * Add MVNA TLS Security Policy (#77) * ✨ IF-5804 Add Operation resource to mVNA LB (#79) * ✨ IF-5804 Add Operation resource to mVNA LB * ✨ IF-5804 Support additional params * ✨ IF-5804 Remove unsupported param * ✨ IF-5804 Add method to normalize boolean parameters * ✨ IF-5804 Apply previously commited changes for rest of resources * ✨ IF-5804 Make code better and more readable * ✨ IF-5804 Add new line to base.py * Follow MVNA api spec changes (#80) * IF-5871 fix parameter name (#81) * Drop MVNA day2 functions (#82) * Delete database and object functions (#83) * Delete database and object sub-command * Delete related files * Enable Update with blank parameter (#84) This PR enables update mvNA relevant objects with following parameters. - "" (blank string) - {} (blank object) Co-authored-by: Keiichi Hikita <keiichi.hikita@w.ntt.com> * IF-6142 fix operator of health monitor (#85) * IF-6142 fix operator of health monitor * IF-6142 fix description of param * Update ecl/mvna/v1/_proxy.py Co-authored-by: ysssasaki <64194789+ysssasaki@users.noreply.github.com> * IF-6142 refix operator Co-authored-by: ysssasaki <64194789+ysssasaki@users.noreply.github.com> * ✨ add bto baremetals api (#86) * ✨ IF-5903 add bto baremetals api * ✨ IF-5903 add bto baremetals api * ✨ IF-5903 add bto baremetals api Co-authored-by: oizaki.atsushi <atsushi.oizaki@ntt.com> * Revert "✨ add bto baremetals api (#86)" (#87) This reverts commit ed4b903. * ✨ IF-6816 add security groups api (#89) - List Sercurity Group - Create Sercurity Group - Show Sercurity Group - Update Sercurity Group - Delete Sercurity Group * ✨ IF-7067 add security group rules api (#90) * 🐛 IF-7068 fix existing api (#91) Co-authored-by: yamazaki.tomoka <tomoka.yamazaki@w.ntt.com> * Revert ":bug: IF-7068 fix existing api (#91)" (#94) This reverts commit 9e70943. * Revert ":sparkles: IF-7067 add security group rules api (#90)" (#95) This reverts commit b8ca37e. * Revert ":sparkles: IF-6816 add security groups api (#89)" (#96) This reverts commit 4c28a92. Co-authored-by: NaoShark <49853899+NaoShark@users.noreply.github.com> Co-authored-by: Manabu Miwa <manabumiwa_info@icloud.com> Co-authored-by: shiso <nooba704@gmail.com> Co-authored-by: Keiichi Hikita <keiichi.hikita@ntt.com> Co-authored-by: Keiichi Hikita <keiichi.hikita@w.ntt.com> Co-authored-by: ysssasaki <64194789+ysssasaki@users.noreply.github.com> Co-authored-by: a-oi-xon <91597807+a-oi-xon@users.noreply.github.com> Co-authored-by: oizaki.atsushi <atsushi.oizaki@ntt.com> Co-authored-by: yamazaki-x <91593437+yamazaki-x@users.noreply.github.com> Co-authored-by: yamazaki.tomoka <tomoka.yamazaki@w.ntt.com>
sugimo-s
added a commit
that referenced
this pull request
Apr 1, 2022
* Add MVNA Resource. (#74) * Support additional mvna parameter (#76) * Support List Query Parameters. * Support changes query parameter. * Support X-MVNA-Request-Id Header Parameter. * Add `ignore_missing` argument to delete_load_balancer function. * Refactoring the code. * Add MVNA TLS Security Policy (#77) * ✨ IF-5804 Add Operation resource to mVNA LB (#79) * ✨ IF-5804 Add Operation resource to mVNA LB * ✨ IF-5804 Support additional params * ✨ IF-5804 Remove unsupported param * ✨ IF-5804 Add method to normalize boolean parameters * ✨ IF-5804 Apply previously commited changes for rest of resources * ✨ IF-5804 Make code better and more readable * ✨ IF-5804 Add new line to base.py * Follow MVNA api spec changes (#80) * IF-5871 fix parameter name (#81) * Drop MVNA day2 functions (#82) * Delete database and object functions (#83) * Delete database and object sub-command * Delete related files * Enable Update with blank parameter (#84) This PR enables update mvNA relevant objects with following parameters. - "" (blank string) - {} (blank object) Co-authored-by: Keiichi Hikita <keiichi.hikita@w.ntt.com> * IF-6142 fix operator of health monitor (#85) * IF-6142 fix operator of health monitor * IF-6142 fix description of param * Update ecl/mvna/v1/_proxy.py Co-authored-by: ysssasaki <64194789+ysssasaki@users.noreply.github.com> * IF-6142 refix operator Co-authored-by: ysssasaki <64194789+ysssasaki@users.noreply.github.com> * ✨ add bto baremetals api (#86) * ✨ IF-5903 add bto baremetals api * ✨ IF-5903 add bto baremetals api * ✨ IF-5903 add bto baremetals api Co-authored-by: oizaki.atsushi <atsushi.oizaki@ntt.com> * Revert "✨ add bto baremetals api (#86)" (#87) This reverts commit ed4b903. * ✨ IF-6816 add security groups api (#89) - List Sercurity Group - Create Sercurity Group - Show Sercurity Group - Update Sercurity Group - Delete Sercurity Group * ✨ IF-7067 add security group rules api (#90) * 🐛 IF-7068 fix existing api (#91) Co-authored-by: yamazaki.tomoka <tomoka.yamazaki@w.ntt.com> * Revert ":bug: IF-7068 fix existing api (#91)" (#94) This reverts commit 9e70943. * Revert ":sparkles: IF-7067 add security group rules api (#90)" (#95) This reverts commit b8ca37e. * Revert ":sparkles: IF-6816 add security groups api (#89)" (#96) This reverts commit 4c28a92. * A oi xon if 5903 bto baremetals (#99) * ✨ IF-5903 add bto baremetals api * ✨ IF-5903 add bto baremetals api * ✨ IF-5903 add bto baremetals api Co-authored-by: oizaki.atsushi <atsushi.oizaki@ntt.com> * Make interfaces optional in create VNA (#100) * ✨ IF-6596 version up Co-authored-by: NaoShark <49853899+NaoShark@users.noreply.github.com> Co-authored-by: Manabu Miwa <manabumiwa_info@icloud.com> Co-authored-by: shiso <nooba704@gmail.com> Co-authored-by: Keiichi Hikita <keiichi.hikita@ntt.com> Co-authored-by: Keiichi Hikita <keiichi.hikita@w.ntt.com> Co-authored-by: ysssasaki <64194789+ysssasaki@users.noreply.github.com> Co-authored-by: a-oi-xon <91597807+a-oi-xon@users.noreply.github.com> Co-authored-by: oizaki.atsushi <atsushi.oizaki@ntt.com> Co-authored-by: yamazaki-x <91593437+yamazaki-x@users.noreply.github.com> Co-authored-by: yamazaki.tomoka <tomoka.yamazaki@w.ntt.com> Co-authored-by: Yoshiki Kashiwabara <91601085+KashiwabaraY@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MVNA API の仕様変更に追随しています。