-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make code and comment more clear #130
Open
yuki-uchida
wants to merge
13
commits into
draft-06
Choose a base branch
from
refactoring/delete_unnecessary_code
base: draft-06
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yuki-uchida
commented
Nov 5, 2024
•
edited
Loading
edited
- delete unnecessary and comment
- add comment
- make processing order easier to understand
- distinguish between send and forward
- send: server to client
- forward: recv thread to write thread in server
- move moqt_client from core to server
- sort and group import
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## draft-06 #130 +/- ##
============================================
- Coverage 65.59% 65.41% -0.18%
============================================
Files 62 63 +1
Lines 3104 3097 -7
============================================
- Hits 2036 2026 -10
- Misses 1068 1071 +3
|
yuki-uchida
force-pushed
the
refactoring/delete_unnecessary_code
branch
from
November 8, 2024 08:34
71b8fd5
to
5c2e54a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.