Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make code and comment more clear #130

Open
wants to merge 13 commits into
base: draft-06
Choose a base branch
from

Conversation

yuki-uchida
Copy link
Collaborator

@yuki-uchida yuki-uchida commented Nov 5, 2024

  • delete unnecessary and comment
  • add comment
  • make processing order easier to understand
  • distinguish between send and forward
    • send: server to client
    • forward: recv thread to write thread in server
  • move moqt_client from core to server
  • sort and group import

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 47.44526% with 72 lines in your changes missing coverage. Please review.

Project coverage is 65.41%. Comparing base (f849b98) to head (5c2e54a).

Additional details and impacted files
@@             Coverage Diff              @@
##           draft-06     #130      +/-   ##
============================================
- Coverage     65.59%   65.41%   -0.18%     
============================================
  Files            62       63       +1     
  Lines          3104     3097       -7     
============================================
- Hits           2036     2026      -10     
- Misses         1068     1071       +3     
Components Coverage Δ
moqt-core 91.19% <66.66%> (-0.36%) ⬇️
moqt-server 53.97% <42.72%> (+0.39%) ⬆️

@yuki-uchida yuki-uchida force-pushed the refactoring/delete_unnecessary_code branch from 71b8fd5 to 5c2e54a Compare November 8, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant