Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Tenant Connection and Approval Request #46

Merged
merged 14 commits into from
Feb 25, 2020
Merged

Support Tenant Connection and Approval Request #46

merged 14 commits into from
Feb 25, 2020

Conversation

shimisho
Copy link
Contributor

@shimisho shimisho commented Feb 5, 2020

Add Tenant Connection and Approval Request.

@shimisho shimisho changed the title Shimisho if 4142 tenant connection support and add approval provider Support Tenant Connection and Approval Request Feb 5, 2020
keiichi-hikita
keiichi-hikita approved these changes Feb 6, 2020
View reviewed changes
Copy link
Contributor

@keiichi-hikita keiichi-hikita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM o/

@kazyshr kazyshr self-requested a review February 6, 2020 02:46
kazyshr
kazyshr requested changes Feb 6, 2020
View reviewed changes
Copy link
Contributor

@kazyshr kazyshr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work 👏
Comments for whole PR:

  • Please use %w instead of %s when wrapping error using fmt.Errorf()
  • Please consider if data sources should be supported or not. Do you have any use cases for tenant connection and approval request?

kazyshr
kazyshr reviewed Feb 12, 2020
View reviewed changes
ecl/util.go Show resolved Hide resolved
kazyshr
kazyshr approved these changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@kazyshr kazyshr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!!!

ghost
ghost approved these changes Feb 25, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:)

@shimisho shimisho merged commit 1aa4c22 into master Feb 25, 2020
@shimisho shimisho deleted the shimisho_IF-4142_tenant_connection_support_and_add_approval_provider branch February 25, 2020 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazyshr kazyshr kazyshr approved these changes

@keiichi-hikita keiichi-hikita keiichi-hikita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shimisho @keiichi-hikita @kazyshr