[Fix]: Table graph select column issue #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nxanil @shashank-nx What is this issue? Please describe either in this PR or in the github issue. |
preshitg
reviewed
Apr 23, 2021
Graphs/Table/index.js
Outdated
| @@ -175,7 +176,7 @@ const TableGraph = (props) => { | |||
| updateScroll, | |||
| } = props; | |||
|
|
|||
| if (!isEmpty(displayColumn)) { | |||
| if (!isEmpty(displayColumn) || isAllColumnSelected === true) { | |||
There was a problem hiding this comment.
!isEmpty(displayColumn) || isAllColumnSelected should suffice since isAllColumnSelected always has a boolean value
@preshitg |
preshitg
approved these changes
Apr 26, 2021
preshitg
pushed a commit
to preshitg/vis-graphs
that referenced
this pull request
Apr 26, 2021
* [Fix]: Table graph select column issue * [Done]: Feedback changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@shashank-nx
Fixed issue #463. Please verify once.
@preshitg
Please review the changes.