Versioning change #286
Merged
Versioning change #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will the bumpver still work as usual? You can check using |
|
Hi @sahiljhawar, yes I gave it a go (a different cmd tho, not committing anything but just running it to output in the stdout) and it did update the versions in both pyproject.toml and init.py |
|
okay, great! @mcoughlin merge? |
|
Yes sir. Just edit the title not to have WIP. @sahiljhawar |
|
@Theodlz any more commits to this? |
|
@sahiljhawar I don't believe so no! We're keeping 0.1.3 here for now, right? |
|
I think so. |
sahiljhawar
merged commit 9edf596
into
nuclear-multimessenger-astronomy:main
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to address the versioning differently, similar to how https://github.com/joblib/joblib does it for example.