Restructure sncosmo.get_bandpass block in get_default_filts_lambdas #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfhealy
merged commit 0b0d245
into
nuclear-multimessenger-astronomy:main
3 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by issues running on a cluster that cannot make external internet connections, this PR restructures a block that gets sncosmo filter bandpasses in
get_default_filts_lambdas. The removed try/except masked informative errors raised on this cluster installation, so it is instead replaced by an if/else specifying the filters that must be loaded asAggregateBandpassrather thanBandpassobjects.megacampsffilters are added to the list that previously included onlyultrasat.