Update of resampling methods #348
Conversation
correlation between chirp mass and mass ratio. Added maximum-mass-constraint as a command, so one can sample from a joint GW+EM posterior and get an upper limit on the TOV mass.
… correlation between chirp mass and mass ratio (and potentially spin in NSBH systems). Added maximum-mass-constraint as a command, so one can sample from a joint GW+EM posterior and get an upper limit on the TOV mass. The TOV solver here is different from the ones already present in eos/tov.py, because here we are interested in the density profile of the star, whereas the other only provides bulk properties. Conversion factors are now fixed to astropy values.
|
you can find a test on the Potsdam cluster at |
|
No, I meant a CI test within the nmma repo |
|
ah ok, like in nmma/tests? |
|
Yes, you can check |
|
I think this should work now 🤞 |
|
@haukekoehn I think usually we don't keep the EOS suite in NMMA directly. I think a better test would just be the same test but with the first 10 EOSs. |
|
Indeed, a full EOS set is way too big for nmma, especially if it is for testing only. I agree with @mcoughlin that 10 EOS should be sufficient |
|
Sure (it was already reduced from 25k EOS originally :D) I would also add some documentation probably. Is there anywhere some info/guidelines how these tests should look like? Because i guess they should mainly show that the code runs and not produce any meaningful results? |
tsunhopang
merged commit 26b30af
into
nuclear-multimessenger-astronomy:main
Added maximum-mass-constraint as a command, so one can sample from a joint GW+EM posterior and get an upper limit on the TOV mass.
The TOV solver here is different from the ones already present in
eos/tov.py, because here we are interested in the density profile of the
star, whereas the other only provides bulk properties.
Conversion factors are now fixed to astropy values.