Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactored systematics code #385

Conversation

sahiljhawar
Copy link
Member

Refactored systematics code to be more versatile. Now it is possible to use all analytical priors from bilby. Docs and tests will follow.

Copy link
Member

@mcoughlin mcoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are all those tests now commented?

@sahiljhawar
Copy link
Member Author

sahiljhawar commented Nov 2, 2024

I have to change few of the tests, that's why commented all the tests for now.

Edit: They are working now.

@sahiljhawar sahiljhawar requested a review from mcoughlin November 4, 2024 13:36
Copy link
Member

@mcoughlin mcoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@tsunhopang tsunhopang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsunhopang tsunhopang merged commit 96cd587 into nuclear-multimessenger-astronomy:main Nov 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants