Direct eos sampling #389
Draft
Direct eos sampling #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Hen42rik is this WIP or more commits will be added to this PR? |
|
@mcoughlin @tsunhopang should we discuss about this? How this is going to be added to the repo? On the main branch or the |
|
@Hen42rik @sahiljhawar @tsunhopang Does it make sense to make thiis sampling its own executable for now, while the classes and everything of course get integrated as normal, and we can slowly converge to everything being called from one sampler code? |
|
@mcoughlin @sahiljhawar @tsunhopang I am working on some more edits and fixes, I plan to ursurpate a longform-update next week or the week after to give an overview of suggested changes. I would suggest du discuss the further process then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains some major refactoring in order to allow direct eos sampling and allow an easier modularisation in future commits.