Implement exceptions in Python and allow to retrieve meaningful information

[MatthieuDartiailh]

This is a first step following the discussion in #161. Feel free to comment and suggest additional changes

[codecov-commenter]

Codecov Report

Merging #162 (f12cba5) into main (26051dd) will increase coverage by 0.20%.
The diff coverage is 88.88%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
+ Coverage   87.73%   87.93%   +0.20%     
==========================================
  Files          24       24              
  Lines        1622     1625       +3     
  Branches       79       74       -5     
==========================================
+ Hits         1423     1429       +6     
+ Misses        185      182       -3     
  Partials       14       14              

[sccolbert]

I am not saying it will. It's just for future-proofing and letting other developers know that this module is imported by the core C extension.

…

On Wed, May 24, 2023 at 2:37 PM Matthieu Dartiailh ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In py/kiwisolver/exceptions.py <#162 (comment)>: > @@ -0,0 +1,47 @@ +# -------------------------------------------------------------------------------------- +# Copyright (c) 2023, Nucleic Development Team. +# +# Distributed under the terms of the Modified BSD License. +# +# The full license is in the file LICENSE, distributed with this software. +# -------------------------------------------------------------------------------------- +"""Kiwi exceptions.""" + I am fine adding a comment but I do not see how that could cause a circular import... — Reply to this email directly, view it on GitHub <#162 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABBQSPDVDILGOARGAVPYTDXHZPQ5ANCNFSM6AAAAAAYN2K7WY> . You are receiving this because you commented.Message ID: ***@***.***>

[sccolbert]

Got it. Thanks!

…

On Wed, May 24, 2023 at 2:39 PM Matthieu Dartiailh ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In py/tests/test_solver.py <#162 (comment)>: > s.addEditVariable(v1, "medium") - with pytest.raises(UnknownEditVariable): + assert e.value.edit_variable is v1 pytest.raises return a custom object ExcInfo. value is the way to reach the original exception. — Reply to this email directly, view it on GitHub <#162 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABBQSJZDT6QO224PRC6BLLXHZPXPANCNFSM6AAAAAAYN2K7WY> . You are receiving this because you commented.Message ID: ***@***.***>

[MatthieuDartiailh]

As a side note @sccolbert could you allow codecov github app ?

[sccolbert]

Done.

…

On Wed, May 24, 2023 at 2:41 PM Matthieu Dartiailh ***@***.***> wrote: As a side note @sccolbert <https://github.com/sccolbert> could you allow codecov github app ? — Reply to this email directly, view it on GitHub <#162 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABBQSJXBAPGFPR5DWNQXXDXHZP6HANCNFSM6AAAAAAYN2K7WY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[MatthieuDartiailh]

Great !