Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARM dll PATH to Windows ARM CIBW job #180

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

ksunden
Copy link
Contributor

@ksunden ksunden commented Jul 5, 2024

This is a follow up to #179 based on adang1345/delvewheel#44

I marked this as a draft as I'd prefer to get it tested prior to merge since I do not actually know for certain that it will work.

I can try to get it to run on my fork (may have to edit the workflow run conditions).

If you are interested, we do have machinery in MPL for running conditionally on a PR based on label presence.
I could try to add that, though may fall into the category of "too much for how often it is used"/"need to be extra careful about not triggering releases unintentionally".

@MatthieuDartiailh
Copy link
Member

I just pushed something on main to test ARM and link against VC2014_1 also. I will let you know how it goes.

@ksunden ksunden force-pushed the cibw_win_arm branch 3 times, most recently from 1e0807b to cc910b2 Compare July 5, 2024 19:46
@MatthieuDartiailh
Copy link
Member

MatthieuDartiailh commented Jul 5, 2024

Can you also remove the DISABLE_FH4 env var. If we bundle the dll there is no reason to use an old one ?

@ksunden ksunden force-pushed the cibw_win_arm branch 4 times, most recently from 48f50a2 to cef7fab Compare July 5, 2024 20:16
@MatthieuDartiailh
Copy link
Member

You can have a look at how pyzmq maintainer dealt with the path discovery issue at https://github.com/zeromq/pyzmq/pull/1951/files

@ksunden
Copy link
Contributor Author

ksunden commented Jul 5, 2024

Okay, I think the version in now should work, at least for now...

Here is a successful fun (from before my last rebase which included your commit taking out the FH4 env var):

https://github.com/ksunden/kiwi/actions/runs/9813199691/job/27098741691#step:10:616

If you wish to adopt pyzmq's finding, I'll leave that to you. A cursory look at that PR looks like it is indeed just automating what I did, but did not read it closely. I left a comment with the tree command I used to get the numbers that were valid.

@ksunden ksunden marked this pull request as ready for review July 5, 2024 20:36
@MatthieuDartiailh MatthieuDartiailh merged commit df19e18 into nucleic:main Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants