Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set translation domain for whole form #12

Merged
merged 1 commit into from
Feb 7, 2020
Merged

Set translation domain for whole form #12

merged 1 commit into from
Feb 7, 2020

Conversation

core23
Copy link
Member

@core23 core23 commented Feb 7, 2020

Subject

Set translation domain for whole form. All form extensions will use NucleosProfileBundle as domain.

@codecov
Copy link

codecov bot commented Feb 7, 2020

Codecov Report

Merging #12 into master will increase coverage by 0.27%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #12      +/-   ##
============================================
+ Coverage     39.58%   39.86%   +0.27%     
  Complexity      122      122              
============================================
  Files            21       21              
  Lines           432      434       +2     
============================================
+ Hits            171      173       +2     
  Misses          261      261
Impacted Files Coverage Δ Complexity Δ
src/Form/Type/RegistrationFormType.php 100% <100%> (ø) 3 <0> (ø) ⬇️
src/Form/Type/ProfileFormType.php 100% <100%> (ø) 3 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84af21c...412a267. Read the comment docs.

@core23 core23 merged commit e612edc into master Feb 7, 2020
@core23 core23 deleted the form-translation branch February 7, 2020 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant