Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove egulias/email-validator dependency #368

Merged
merged 2 commits into from
Sep 27, 2021

Conversation

alexsegura
Copy link
Contributor

When using this bundle, we can't use egulias/email-validator at version 3.x

However, Symfony allows it

https://github.com/symfony/validator/blob/7474c6839fb9386e98afc478047500e90230fe83/composer.json#L45

@core23
Copy link
Member

core23 commented Sep 25, 2021

Thanks for your PR @alexsegura

I wonder why this is a required lib for this bundle. IMHO you can completely remove the dependency.

@alexsegura
Copy link
Contributor Author

It's needed when using the Email constraint with mode = strict.

So yes, it seems we can remove it, as this bundle is not using the strict mode (or I didn't find it)

<property name="email">
<constraint name="NotBlank">
<option name="message">nucleos_user.email.blank</option>
<option name="groups"/>
</constraint>
<constraint name="Length">
<option name="min">2</option>
<option name="minMessage">nucleos_user.email.short</option>
<option name="max">180</option>
<option name="maxMessage">nucleos_user.email.long</option>
<option name="groups"/>
</constraint>
<constraint name="Email">
<option name="message">nucleos_user.email.invalid</option>
<option name="groups"/>
</constraint>
</property>

@core23 core23 changed the title Allow egulias/email-validator 3.x. Remove egulias/email-validator dependency Sep 27, 2021
@core23 core23 added this to the 1.7.0 milestone Sep 27, 2021
@core23 core23 merged commit a8e550c into nucleos:1.7.x Sep 27, 2021
@core23
Copy link
Member

core23 commented Sep 27, 2021

Thanks @alexsegura

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants