Skip to content
This repository has been archived by the owner on Feb 26, 2023. It is now read-only.

Move configuration to PHP #70

Merged
merged 2 commits into from
Jul 4, 2020
Merged

Move configuration to PHP #70

merged 2 commits into from
Jul 4, 2020

Conversation

core23
Copy link
Member

@core23 core23 commented Jul 4, 2020

Subject

Allow loading services without XML extension.

@codecov
Copy link

codecov bot commented Jul 4, 2020

Codecov Report

Merging #70 into main will increase coverage by 1.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #70      +/-   ##
============================================
+ Coverage     45.07%   46.29%   +1.22%     
  Complexity       91       91              
============================================
  Files            17       20       +3     
  Lines           284      324      +40     
============================================
+ Hits            128      150      +22     
- Misses          156      174      +18     
Impacted Files Coverage Δ Complexity Δ
...rc/DependencyInjection/NucleosShariffExtension.php 100.00% <100.00%> (ø) 8.00 <0.00> (ø)
src/Resources/config/action.php 100.00% <100.00%> (ø) 0.00 <0.00> (?)
src/Resources/config/block.php 100.00% <100.00%> (ø) 0.00 <0.00> (?)
src/Resources/config/services.php 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...pendencyInjection/Compiler/ShariffCompilerPass.php 62.50% <0.00%> (-37.50%) 2.00% <0.00%> (ø%)
src/Service/Vk.php 0.00% <0.00%> (-20.00%) 3.00% <0.00%> (ø%)
src/Service/Xing.php 0.00% <0.00%> (-18.19%) 4.00% <0.00%> (ø%)
src/Service/Buffer.php 0.00% <0.00%> (-18.19%) 4.00% <0.00%> (ø%)
src/Service/AddThis.php 0.00% <0.00%> (-18.19%) 4.00% <0.00%> (ø%)
src/Service/StumbleUpon.php 0.00% <0.00%> (-18.19%) 4.00% <0.00%> (ø%)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d6b9ba...4fa17eb. Read the comment docs.

@core23 core23 merged commit d4de735 into main Jul 4, 2020
@core23 core23 deleted the php-files branch October 23, 2020 21:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

1 participant