Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Asset for DefaultAvatar Url #415

Merged
merged 2 commits into from
Dec 3, 2021
Merged

Use Asset for DefaultAvatar Url #415

merged 2 commits into from
Dec 3, 2021

Conversation

Hanmac
Copy link
Contributor

@Hanmac Hanmac commented Dec 2, 2021

Closes #413

Subject

This Change makes the Default Avatar use the Asset Component to get the correct path of the file

core23
core23 requested changes Dec 2, 2021
View reviewed changes
src/Avatar/StaticAvatarResolver.php Outdated Show resolved Hide resolved
@core23 core23 added this to the 2.2.0 milestone Dec 3, 2021
@core23 core23 merged commit 0a95d3c into nucleos:2.2.x Dec 3, 2021
@core23
Copy link
Member

core23 commented Dec 3, 2021

Thanks @Hanmac

@Hanmac Hanmac deleted the assetPackage branch December 3, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@core23 core23 core23 requested changes

@nucleos-bot nucleos-bot Awaiting requested review from nucleos-bot nucleos-bot is a code owner

Assignees
No one assigned
Labels
Enhancement
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

Default Avatar doesn't respect the location of the assets
2 participants
@Hanmac @core23