Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make service aliases public #30

Merged
merged 1 commit into from
Jan 19, 2020
Merged

Make service aliases public #30

merged 1 commit into from
Jan 19, 2020

Conversation

core23
Copy link
Member

@core23 core23 commented Jan 19, 2020

Subject

In order to extend this bundle, there should be some default aliases.

@codecov
Copy link

codecov bot commented Jan 19, 2020

Codecov Report

Merging #30 into master will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master      #30     +/-   ##
===========================================
+ Coverage     55.97%   56.08%   +0.1%     
- Complexity      461      463      +2     
===========================================
  Files            58       58             
  Lines          1263     1266      +3     
===========================================
+ Hits            707      710      +3     
  Misses          556      556
Impacted Files Coverage Δ Complexity Δ
src/DependencyInjection/NucleosUserExtension.php 86.04% <100%> (+0.5%) 31 <0> (ø) ⬇️
src/EventListener/LocaleEventSubscriber.php
src/EventListener/LocaleEventListener.php 15.25% <0%> (ø) 27% <0%> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d9aea5...c9173ee. Read the comment docs.

@core23 core23 merged commit cc8f3d8 into master Jan 19, 2020
@core23 core23 deleted the dev branch January 19, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant