Fix symfony deprecation #299
core23continuous-integration.yml
on: push
run
/
Generate test matrix
3s
Matrix: run / Code Coverage
Matrix: run / Coding Standards
Matrix: run / Lint composer.json
Matrix: run / Mutation Tests
Matrix: run / Static Code Analysis
Matrix: run / tests
Annotations
23 warnings
|
run / Code Coverage (8.3)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
run / Coding Standards (8.3)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
run / Static Code Analysis (8.3)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
run / Mutation Tests (8.3)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
run / Mutation Tests (8.3):
src/Action/BrowseMediaAction.php#L74
Escaped Mutant for Mutator "MethodCallRemoval":
@@ @@
*/
public function __invoke(Request $request): Response
{
- $this->admin->checkAccess('list');
+
$filters = $request->query->all('filter');
// set the default context
$context = $this->getContext($filters);
|
|
run / Mutation Tests (8.3):
src/Action/BrowseMediaAction.php#L87
Escaped Mutant for Mutator "MethodCallRemoval":
@@ @@
$rootCategory = $this->getRootCategoryForContext($context);
}
$datagrid = $this->admin->getDatagrid();
- $datagrid->setValue('context', null, $context);
+
$datagrid->setValue('providerName', null, $this->admin->getPersistentParameter('provider'));
if (null !== $rootCategory && [] === $filters) {
$datagrid->setValue('category', null, $rootCategory->getId());
|
|
run / Mutation Tests (8.3):
src/Action/BrowseMediaAction.php#L88
Escaped Mutant for Mutator "MethodCallRemoval":
@@ @@
}
$datagrid = $this->admin->getDatagrid();
$datagrid->setValue('context', null, $context);
- $datagrid->setValue('providerName', null, $this->admin->getPersistentParameter('provider'));
+
if (null !== $rootCategory && [] === $filters) {
$datagrid->setValue('category', null, $rootCategory->getId());
}
|
|
run / Mutation Tests (8.3):
src/Action/BrowseMediaAction.php#L90
Escaped Mutant for Mutator "Identical":
@@ @@
$datagrid = $this->admin->getDatagrid();
$datagrid->setValue('context', null, $context);
$datagrid->setValue('providerName', null, $this->admin->getPersistentParameter('provider'));
- if (null !== $rootCategory && [] === $filters) {
+ if (null !== $rootCategory && [] !== $filters) {
$datagrid->setValue('category', null, $rootCategory->getId());
}
if (null !== $this->categoryManager && $request->query->has('category')) {
|
|
run / Mutation Tests (8.3):
src/Action/BrowseMediaAction.php#L94
Escaped Mutant for Mutator "NotIdentical":
@@ @@
if (null !== $rootCategory && [] === $filters) {
$datagrid->setValue('category', null, $rootCategory->getId());
}
- if (null !== $this->categoryManager && $request->query->has('category')) {
+ if (null === $this->categoryManager && $request->query->has('category')) {
$category = $this->categoryManager->findOneBy(['id' => $request->query->get('category'), 'context' => $context]);
if (null !== $category) {
$datagrid->setValue('category', null, $category->getId());
|
|
run / Mutation Tests (8.3):
src/Action/BrowseMediaAction.php#L94
Escaped Mutant for Mutator "LogicalAndSingleSubExprNegation":
@@ @@
if (null !== $rootCategory && [] === $filters) {
$datagrid->setValue('category', null, $rootCategory->getId());
}
- if (null !== $this->categoryManager && $request->query->has('category')) {
+ if (null !== $this->categoryManager && !$request->query->has('category')) {
$category = $this->categoryManager->findOneBy(['id' => $request->query->get('category'), 'context' => $context]);
if (null !== $category) {
$datagrid->setValue('category', null, $category->getId());
|
|
run / Mutation Tests (8.3):
src/Action/BrowseMediaAction.php#L180
Escaped Mutant for Mutator "CastString":
@@ @@
} else {
$context = $filters['context']['value'];
}
- return (string) $context;
+ return $context;
}
/**
* @psalm-param DatagridInterface<ProxyQueryInterface<MediaInterface>> $datagrid
|
|
run / Mutation Tests (8.3):
src/Action/UploadMediaAction.php#L91
Escaped Mutant for Mutator "MethodCallRemoval":
@@ @@
$media->setBinaryContent($file);
$media->setProviderName($provider);
$media->setContext($context);
- $media->setCategory($this->getCategory($context));
+
$this->mediaManager->save($media);
$this->admin->createObjectSecurity($media);
$format = $this->pool->getProvider($provider)->getFormatName($media, $request->query->get('format', MediaProviderInterface::FORMAT_REFERENCE));
|
|
run / Mutation Tests (8.3):
src/Action/UploadMediaAction.php#L102
Escaped Mutant for Mutator "ArrayItemRemoval":
@@ @@
$this->mediaManager->save($media);
$this->admin->createObjectSecurity($media);
$format = $this->pool->getProvider($provider)->getFormatName($media, $request->query->get('format', MediaProviderInterface::FORMAT_REFERENCE));
- return new Response($this->twig->render($this->template, ['action' => 'ckeditor-browse', 'object' => $media, 'format' => $format]));
+ return new Response($this->twig->render($this->template, ['object' => $media, 'format' => $format]));
}
private function getCategory(?string $context): ?CategoryInterface
{
|
|
run / Mutation Tests (8.3):
src/Action/UploadMediaAction.php#L113
Escaped Mutant for Mutator "Identical":
@@ @@
private function getCategory(?string $context): ?CategoryInterface
{
$categoryId = $this->admin->getPersistentParameter('category');
- if (null === $this->categoryManager || null === $categoryId) {
+ if (null === $this->categoryManager || null !== $categoryId) {
return null;
}
$category = $this->categoryManager->find($categoryId);
|
|
run / Lint composer.json (8.3)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
run / Test: PHP 8.2, Symfony 6.4, lowest)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
run / Test: PHP 8.3, Symfony 6.4, lowest)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
run / Test: PHP 8.2, Symfony 6.4, highest)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
run / Test: PHP 8.3, Symfony 7.0, highest)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
run / Test: PHP 8.2, Symfony 7.0, lowest)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
run / Test: PHP 8.3, Symfony 6.4, highest)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
run / Test: PHP 8.3, Symfony 7.0, lowest)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
run / Test: PHP 8.2, Symfony 7.0, highest)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|