Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and build tools #87

Merged
merged 10 commits into from
Jul 31, 2023
Merged

Update dependencies and build tools #87

merged 10 commits into from
Jul 31, 2023

Conversation

MatsG23
Copy link
Collaborator

@MatsG23 MatsG23 commented May 18, 2023

No description provided.

@MatsG23 MatsG23 added blocked Something that can not be fixed by the project itself currently due to circumstances do-not-merge labels May 18, 2023
@MatsG23
Copy link
Collaborator Author

MatsG23 commented May 29, 2023

Should we for now use

app_settings:
    git: https://github.com/spencerccf/app_settings.git

in pubspec.yaml as a temporary fix until version 4.3.0 is published?

@nucleus-ffm
Copy link
Owner

If that works without any problems, we can do that. We just use the plugin for a button in the settings to open the Android notification settings. Maybe we can even remove the plugin and replace it with a platform-specific call.

@MatsG23
Copy link
Collaborator Author

MatsG23 commented May 29, 2023

If we would implement opening this specific settings page as a platform-specific call, the bundle size would also be reduced a bit (one less plugin).
In the WelcomeView, we do already open the settings page for adding a battery excemption for the app using a platform-specific call. Doing the same for the notifications may be very similar to the short code we use for that.
https://github.com/nucleus-ffm/foss_warn/blob/main/android/app/src/main/kotlin/de/nucleus/foss_warn/MainActivity.kt#L42

@MatsG23
Copy link
Collaborator Author

MatsG23 commented Jun 26, 2023

The platform-specific call for Android is finished. But I cannot test it right now because of flutter/flutter#128204

@MatsG23 MatsG23 removed blocked Something that can not be fixed by the project itself currently due to circumstances do-not-merge labels Jul 29, 2023
@MatsG23 MatsG23 requested a review from nucleus-ffm July 29, 2023 13:26
Copy link
Owner

@nucleus-ffm nucleus-ffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and works as expected. We can merge the branch from my side.

@MatsG23 MatsG23 merged commit d32b140 into main Jul 31, 2023
1 check passed
@MatsG23 MatsG23 deleted the update branch July 31, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants