Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes #95

Merged
merged 47 commits into from
Oct 26, 2023
Merged

Bugfixes #95

merged 47 commits into from
Oct 26, 2023

Conversation

nucleus-ffm
Copy link
Owner

@nucleus-ffm nucleus-ffm linked an issue Oct 1, 2023 that may be closed by this pull request
lib/main.dart Outdated Show resolved Hide resolved
lib/main.dart Outdated Show resolved Hide resolved
lib/services/alertSwiss.dart Outdated Show resolved Hide resolved
lib/services/apiHandler.dart Outdated Show resolved Hide resolved
lib/services/apiHandler.dart Outdated Show resolved Hide resolved
lib/widgets/dialogs/SortByDialog.dart Outdated Show resolved Hide resolved
lib/widgets/dialogs/SortByDialog.dart Outdated Show resolved Hide resolved
lib/widgets/dialogs/SortByDialog.dart Outdated Show resolved Hide resolved
lib/widgets/dialogs/SortByDialog.dart Outdated Show resolved Hide resolved
lib/widgets/dialogs/legacyWarningDialog.dart Show resolved Hide resolved
@MatsG23
Copy link
Collaborator

MatsG23 commented Oct 24, 2023

Is the internal phone number change completed?

@MatsG23
Copy link
Collaborator

MatsG23 commented Oct 24, 2023

For Android 14 I have added the function to request the SCHEDULE_EXACT_ALARM permission. Sadly this is a permission that needs to be given in the settings (the app opens the matching settings page - comparable to the battery excemption as it was before).
I think that this needs a welcome page for the user to explain. Similar could optionally be done for the notification permission. The problem is that those one or two new pages would be a conditional welcome item (depending on the Android version). This is not compatible with our current aproach, I think. What are your thoughts on this?

@nucleus-ffm
Copy link
Owner Author

For Android 14 I have added the function to request the SCHEDULE_EXACT_ALARM permission. [...]

I would suggest doing this in a later version. Andoid 14 is really new and I think we can do this later. I still need to think about a solution. But we could also just show an alertDialog to ask for permission (for now).

@nucleus-ffm
Copy link
Owner Author

Is the internal phone number change completed?

You mean that the app converts e.g. the German numbers to international numbers? No, I haven't implemented that yet and I will try it later. We can create a issue to not forget this feature.

@MatsG23
Copy link
Collaborator

MatsG23 commented Oct 25, 2023

I think the old web address extractor did not work with subdomains because it had some logic included that cuts after the first dot and adds a "https". This was likely made with only "www" subdomains in mind. I now created a regex and tests for that too and slightly improved the extraction from a hyperlinks (by searching for href=" instead of only the ").

Copy link
Owner Author

@nucleus-ffm nucleus-ffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@nucleus-ffm nucleus-ffm merged commit f7f947f into main Oct 26, 2023
1 check passed
@nucleus-ffm nucleus-ffm deleted the bugfixes branch November 7, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort order reversed Crash Clicked on a notification but the announcements list was empty
2 participants