Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't split escaped function labels #164

Conversation

yaelgen
Copy link
Contributor

@yaelgen yaelgen commented Feb 2, 2023

A fix for: ML-3224

Copy link
Collaborator

@alonmr alonmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like the logic.
Please add some tests for edge cases like empty, key without dots, etc.

nuclio/config.py Outdated Show resolved Hide resolved
nuclio/config.py Outdated Show resolved Hide resolved
tests/test_utils.py Outdated Show resolved Hide resolved
@alonmr alonmr changed the title Fix for unable to deploy serving functions with labels that have special characters Don't split escaped function labels Feb 2, 2023
@yaelgen yaelgen marked this pull request as ready for review February 2, 2023 09:57
@yaelgen yaelgen requested a review from alonmr February 2, 2023 09:57
Copy link
Collaborator

@alonmr alonmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! minor naming suggestion

tests/test_utils.py Outdated Show resolved Hide resolved
@alonmr alonmr merged commit 3f9a249 into nuclio:development Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants