Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove statefullness from DKG instances #183

Merged
merged 6 commits into from
Mar 19, 2024

Conversation

piotr-roslaniec
Copy link

@piotr-roslaniec piotr-roslaniec commented Feb 14, 2024

Type of PR:

  • Feature
  • Refactor

Required reviews:

  • 1

What this does:

  • Removes statefulness from struct Dkg
  • Rewrites logic that relied on the internal state, for example, transcript verification
  • Removes deprecated structures and methods (mostly related to Message)
  • Fixes some serde serialization issues that came up in Key share refreshing ceremony refactor #175

Issues fixed/closed:

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

@piotr-roslaniec piotr-roslaniec force-pushed the remove-dkg-state branch 4 times, most recently from a9e7f44 to 2e7835c Compare February 19, 2024 13:21
@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2024

Codecov Report

Attention: 139 lines in your changes are missing coverage. Please review.

Comparison is base (72b8484) 78.28% compared to head (07c476c) 79.28%.
Report is 1 commits behind head on main.

Files Patch % Lines
ferveo/src/bindings_python.rs 59.33% 61 Missing ⚠️
ferveo/src/api.rs 94.72% 38 Missing ⚠️
ferveo-tdec/src/decryption.rs 39.13% 14 Missing ⚠️
ferveo/src/bindings_wasm.rs 0.00% 9 Missing ⚠️
ferveo/src/dkg.rs 92.62% 9 Missing ⚠️
ferveo-tdec/src/key_share.rs 50.00% 3 Missing ⚠️
ferveo/src/refresh.rs 98.63% 3 Missing ⚠️
ferveo-common/src/keypair.rs 0.00% 1 Missing ⚠️
ferveo/src/pvss.rs 99.24% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
+ Coverage   78.28%   79.28%   +1.00%     
==========================================
  Files          24       24              
  Lines        5066     5721     +655     
==========================================
+ Hits         3966     4536     +570     
- Misses       1100     1185      +85     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cygnusv cygnusv changed the base branch from main to rocknroll March 19, 2024 09:43
@piotr-roslaniec piotr-roslaniec merged commit aa69b36 into nucypher:rocknroll Mar 19, 2024
11 checks passed
@piotr-roslaniec piotr-roslaniec deleted the remove-dkg-state branch March 19, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of g_inv and h_inv in the API Remove the remainder of statfulness from the DKG instances
2 participants