Api updates corresponding to post-0.2 rust-umbral PRs
#272
Conversation
…()` instead of `bytes()`
| sk = skf.secret_key_by_label(label) | ||
| return bytes(skf), bytes(sk) | ||
| derived_skf = skf.secret_key_factory_by_label(skf_label) | ||
| sk = derived_skf.secret_key_by_label(key_label) |
There was a problem hiding this comment.
Should it be by_label or from_label?
There was a problem hiding this comment.
That would also be my guess, but I think from prefix is widely accepted as a naming convention for From<> trait implementation.
There was a problem hiding this comment.
"by_label" is a leftover from PyUmbral 0.1. from is indeed used generally for constructors.
Come to think of it, perhaps make_secret_key()/make_secret_key_factory() (or derive_, borrowing from PyUmbral 0.1) would be a better name for these methods. by_label in my mind implies that there is some lookup going on and not creation.
| @@ -53,7 +50,7 @@ def serialized_size(cls): | |||
| def _from_exact_bytes(cls, data: bytes): | |||
| return cls(CurveScalar._from_exact_bytes(data)) | |||
|
|
|||
| def __bytes__(self) -> bytes: | |||
| def to_secret_bytes(self) -> bytes: | |||
| @@ -125,6 +145,14 @@ def secret_key_by_label(self, label: bytes) -> SecretKey: | |||
|
|
|||
There was a problem hiding this comment.
Not related to this PR but we discussed this extra hoop before in discord (https://discord.com/channels/411401661714792449/411401661714792451/860193967923527730)
There was a problem hiding this comment.
Yep, I remember - see my concerns in nucypher/rust-umbral#64
|
The discussion about hashing to scalars is happening in nucypher/rust-umbral#35 . The rest is ok to mere since nucypher/rust-umbral#64 is merged. |
Already merged
rust-umbralPRs:SecretKeyandSecretKeyFactoryserializable viato_secret_bytes()instead ofbytes(), and added aSerializableSecretbase class (Make sure secret data is zeroized on drop and not copied around rust-umbral#53)SecretKey.__eq__()(Make sure secret data is zeroized on drop and not copied around rust-umbral#53)VerifiedCapsuleFrag.from_verified_bytes()(AddVerifiedCapsuleFrag::from_verified_bytes()rust-umbral#63)SecretKeyFactoryconstructors rust-umbral#64)SecretKeyFactory.secret_key_factory_by_label()(AdditionalSecretKeyFactoryconstructors rust-umbral#64)SecretKeyFactory.from_secure_randomness()and.seed_size()(AdditionalSecretKeyFactoryconstructors rust-umbral#64)