New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple wasm-pack targets #60

Merged

fjarri merged 2 commits into nucypher:master from piotr-roslaniec:packaging

Jul 7, 2021

Contributor

piotr-roslaniec commented Jul 6, 2021 •

edited

Loading

This PR makes it possible to use umbral-pre NPM package both in the browser and on Node.js. This is done using multiple wasm-pack build targets and multiple package.json entry-points:

  "main": "pkg-node/umbral_pre_wasm.js",
  "browser": "pkg-bundler/umbral_pre_wasm.js",
  "types": "umbral_pre_wasm.d.ts"

Other changes:

Fixes in example.js
Examples for both browser and Node.js

There are a lot of line changes, but these are mostly examples and other boilerplates.


Add support for multiple WASM targets

a5ecd00

piotr-roslaniec requested review from fjarri and vepkenez

July 6, 2021 14:31

fjarri reviewed

View reviewed changes

umbral-pre-wasm/Cargo.toml Outdated Show resolved Hide resolved

fjarri reviewed

View reviewed changes

umbral-pre-wasm/.gitignore Show resolved Hide resolved

fjarri reviewed

View reviewed changes

umbral-pre-wasm/example-bundler/yarn.lock Show resolved Hide resolved

fjarri reviewed

View reviewed changes

umbral-pre-wasm/pkg-template/.gitignore Outdated Show resolved Hide resolved

fjarri reviewed

View reviewed changes

umbral-pre-wasm/pkg-template/README.md Outdated Show resolved Hide resolved

fjarri reviewed

View reviewed changes

umbral-pre-wasm/pkg-template/README.md Outdated Show resolved Hide resolved


Update package template

72b8d0a

fjarri merged commit eba7e7f into nucypher:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment