Make JetBrains.Annotations a private reference #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahma
force-pushed
the
explicit-stj-and-ja
branch
3 times, most recently
from
2c4f41e
to
e228a66
Compare
* only reference STJ on netstandard
lahma
force-pushed
the
explicit-stj-and-ja
branch
from
e228a66
to
626b1a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a vanity change. Removes JetBrains.Annotations as a true dependency and also only refers to STJ if doesn't come in the box on the target platform. Basically cleans up dependency tree a bit with some csproj noise. Can totally understand if not wanted.
So basically these will go away
I confirm that the pull-request: