feat: add support for darwin/arm64 arch #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rich Lander <lander2k2@protonmail.com>
Signed-off-by: Rich Lander <lander2k2@protonmail.com>
The noctx linter checks for http requests that don't pass in `context.Context`. This project does not have any requests that are in any exported packages so we don't need it. Signed-off-by: Rich Lander <lander2k2@protonmail.com>
Signed-off-by: Rich Lander <lander2k2@protonmail.com>
Signed-off-by: Rich Lander <lander2k2@protonmail.com>
scottd018
requested changes
Oct 14, 2022
| @@ -78,19 +80,19 @@ jobs: | |||
| - name: Standalone Operator | |||
| artifact: standalone-codebase | |||
| test-workload-path: test/cases/standalone | |||
| go-version: 1.17 | |||
| go-version: 1.19 | |||
There was a problem hiding this comment.
@lander2k2 we should not change all of the go-version lines to 1.19. This would effectively test all cases (standalone, collection, edge-standalone, edge-collection) twice with the same version of go. The purpose of having 2 different tests for different versions is that we should be supporting 2 versions of go (current, and 1 prior release) because not everyone will upgrade to the latest version right away.
Suggestion is that the edge cases should be tested with the previous version (1.18). This would mean that lines 87, 95, 155, and 165 should read go-version: 1.18. This would allow us coverage for testing both functional and e2e tests would be supported for both versions of go.
Signed-off-by: Rich Lander <lander2k2@protonmail.com>
lander2k2
force-pushed
the
kubebuilder-v4-alpha
branch
from
eb23d82 to
66369fe
Compare
Signed-off-by: Rich Lander <lander2k2@protonmail.com>
Signed-off-by: Rich Lander <lander2k2@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rich Lander lander2k2@protonmail.com