Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type annotation for response #28

Closed
odanado opened this issue Mar 18, 2021 · 5 comments · Fixed by #77
Closed

Add type annotation for response #28

odanado opened this issue Mar 18, 2021 · 5 comments · Fixed by #77

Comments

@odanado
Copy link
Contributor

odanado commented Mar 18, 2021

There are no type annotations in backlog.ts. This detracts from the developer experience.

I am interested in this task. Can I work on it?
@mmktomato
Copy link
Member

Sure!
Do you mean about return types? Parameters have types already. https://github.com/nulab/backlog-js/blob/master/src/backlog.ts

@odanado
Copy link
Contributor Author

odanado commented Mar 21, 2021

Do you mean about return types?

Yes.
But, most of the return types are of type any, which can be confusing for developers.

@mmktomato
Copy link
Member

Good.
Let me know if you have any problems on the implementation.

mmktomato pushed a commit that referenced this issue May 11, 2023
Add responce types for Space, Project, User, Activity #28
aaae5d6
@mmktomato
Copy link
Member

I'm working on this issue. This will come with some breaking changes.

mmktomato pushed a commit that referenced this issue May 12, 2023
Add responce types for AttachmentFile, DiskUsage #28
3758ad2
mmktomato pushed a commit that referenced this issue May 15, 2023
Add responce types for IssueType, Priority, Resolution, Start #28
59e3e89
mmktomato pushed a commit that referenced this issue May 16, 2023
Add responce types for Status, Category, Version #28
be7a772
mmktomato pushed a commit that referenced this issue May 19, 2023
Add responce types for CustomField, SharedFile, Issue #28
644fbfa
mmktomato pushed a commit that referenced this issue May 22, 2023
Add responce types for Tag, History, WikiCount #28
53da8fb
mmktomato pushed a commit that referenced this issue May 23, 2023
Add responce types for Wiki, WikiListItem, RecentlyViewedIssue, Recen…
df00e8d 
…tlyViewedWiki, RecentlyViewedProject #28
mmktomato pushed a commit that referenced this issue May 24, 2023
Add responce types for SpaceNotification, IssueCommentNotification #28
f89b625
mmktomato pushed a commit that referenced this issue May 25, 2023
Add responce types for IssueComment, PullRequestComment #28
b794054
mmktomato added a commit that referenced this issue May 30, 2023
@mmktomato
Add responce types for PullRequest, Git, WatchingList #28
71f7802
mmktomato added a commit that referenced this issue May 31, 2023
@mmktomato
Add responce types for Group #28
6b3f755
mmktomato added a commit that referenced this issue Jun 1, 2023
@mmktomato
Add responce types for Team, ProjectTeam, ProjectUser, ProjectAdminis…
823e117 
…trator #28
mmktomato added a commit that referenced this issue Jun 2, 2023
@mmktomato
Add responce types for Notification, Webhook, License, RateLimit, Iss…
29effcb 
…ueParticipants #28
@mmktomato mmktomato mentioned this issue Jun 2, 2023
Merged
@mmktomato
Copy link
Member

Done.
The details of breaking changes: #77 (comment)

@mmktomato mmktomato mentioned this issue Jul 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add type annotation for response nulab/backlog-js
2 participants
@mmktomato @odanado