-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Migrate to Vite #31
Conversation
I once again, hit CSP wall... Vite doesn't have REF: vitejs/vite#9719 Update: Fixed by using vitejs/vite#9719 (comment) (plugin workaround) and vitejs/vite#11864 (patch). Also, important to note that the CSP issue seems to only happened on dev env, |
I don't do crypto
Everything seems to work fine, well except on prod... it keep throwing Caused by Goober: export let update = (css, sheet, append, cssToReplace) => {
cssToReplace
? (sheet.data = sheet.data.replace(cssToReplace, css)) // the problematic part, sheet is null
: sheet.data.indexOf(css) === -1 &&
(sheet.data = append ? css + sheet.data : sheet.data + css);
}; Could be related to cristianbote/goober#500 Update: For some reason Update: Fixed by patching |
This reverts commit 7c4e15f.
Another error after goober's Update: Fixed, we'll use GitHub's hotkey |
Most if not everything is working now, should be ready to be merged. |
Closes #27
REF: https://www.sitepoint.com/webpack-vite-migration/